Botspot / youtubuddy

Search/Watch/Download YouTube videos with a lightweight, interactive tool
GNU General Public License v3.0
36 stars 10 forks source link

Anyone having "infinite search" issues? #13

Closed Botspot closed 3 years ago

Botspot commented 3 years ago

I've noticed that for some searches, youtubuddy tries to load the results forever, but never succeeds.

Upon closer investigation, I believe I've found a bug in youtube-dl's source code. I've opened an issue on the youtube-dl repository, but it was closed almost immediately because some guy "can't reproduce" it.

Can you guys try running this command and seeing if your youtube-dl has the same issue as mine does?

youtube-dl -sv --print-json ytsearch1:battlebots
# and
youtube-dl -sv --print-json ytsearch1:youtubuddy
# Both of the above commands should produce A TON of output. If they don't, then you've experienced the same bug I found!

If the same bug occurs for you, I encourage you to leave a comment on the youtube-dl issue, saying that the bug affects you too.

Itai-Nelken commented 3 years ago

are both the commands supposed to be the same? anyway they both create a lot of output.

Botspot commented 3 years ago

are both the commands supposed to be the same?

No they are not. There, I've fixed it.

Itai-Nelken commented 3 years ago

the first command (youtube-dl -sv --print-json ytsearch1:battlebots) returns a ton of output, but the 2nd one doesn't. here is the output of it (youtube-dl -sv --print-json ytsearch1:youtubuddy)

pi@Twisterpi4-ultra-4gb:~ $ youtube-dl -sv --print-json ytsearch1:youtubuddy
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-sv', u'--print-json', u'ytsearch1:youtubuddy']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2020.12.31
[debug] Python version 2.7.16 (CPython) - Linux-5.4.79-v7l+-armv7l-with-debian-10.7
[debug] exe versions: ffmpeg 4.1.6-1, ffprobe 4.1.6-1, phantomjs 5, rtmpdump 2.4
[debug] Proxy map: {}
Botspot commented 3 years ago

The second one didn't return any output? That is good news! Please consider leaving a comment on the youtube-dl issue, saying that the bug affects you too.

NoozAbooz commented 3 years ago

@Botspot Hey, I've had a similar issue, but with a different bug in the youtubuddy code. When you add a youtube-dl flag, there needs to be a space in front or else it infinitely searches.

Botspot commented 3 years ago

@Botspot Hey, I've had a similar issue, but with a different bug in the youtubuddy code. When you add a youtube-dl flag, there needs to be a space in front or else it infinitely searches.

What line in the code needs a space character?

NoozAbooz commented 3 years ago

I meant as in that when I add a flag, so for example -f 135+140, it searches infinitely. I believe that happens due to a bug where the code doesn't add a space when searching, and does something like youtube-dl-f 135+140 instead of youtube-dl -f 135+140

Itai-Nelken commented 3 years ago

I always have a youtube-dl flag, and I never got a infinite serach. I also just tried -f 135+140 and it still doesn't search ininitely.

Itai-Nelken commented 3 years ago

@Botspot why not make youtubuddy to download and compile youtube-dl until the updated version is added to pip

Botspot commented 3 years ago

@Botspot why not make youtubuddy to download and compile youtube-dl until the updated version is added to pip

How long does it take to compile?

Itai-Nelken commented 3 years ago

How long does it take to compile?

around 7 seconds (on a pi4 4gb stock clock speed using 4 threads) not including the git clone. the git clone took me about 30 seconds with my super bad ~5mbits internet, so I would say it will take less than 30 seconds average.

Itai-Nelken commented 3 years ago

@Botspot the new version is available from pip. https://pypi.org/project/youtube_dl/

Botspot commented 3 years ago

@Botspot the new version is available from pip. https://pypi.org/project/youtube_dl/

Awesome! I've updated the gui script to upgrade youtube-dl. Would anyone like to try it?

Itai-Nelken commented 3 years ago

Awesome! I've updated the gui script to upgrade youtube-dl. Would anyone like to try it?

I 'm pretty sure it upgraded youtube-dl fine and I have no more infinite search issue.