Bottelet / DaybydayCRM

DaybydayCRM an open-source CRM, to help you keep track of your daily workflow.
https://daybydaycrm.com
2.26k stars 755 forks source link

Having country list hard coded is restrictive #193

Closed Nirys closed 3 years ago

Nirys commented 4 years ago

We're looking at adopting DayByDay for a client project, however being based in Australia we don't have an option for Australia out of the box.

Would you consider having this data (country, currency code, etc.) in tables so that it's more easily extensible? I'm totally keen to submit a PR for this if it would be a welcome feature.

Bottelet commented 4 years ago

@Nirys I would be open to this, but can you tell me your use-case? The reason it is on a file currently is because it's static information, and the users can't change any of the settings.

Nirys commented 4 years ago

@Bottelet , I guess I see a couple of things here:

I'm not necessarily suggesting that there's a front end to edit the countries, merely that they get moved out of an Enum into a database table. That way it's possible to add/update/remove them from migrations in a vendor module or similar. I prefer to do extensions/modifications as vendor packages so that the core code base remains in line with current published head.

Bottelet commented 3 years ago

@Nirys I will stick with it being in files for now, as I don't see the advantages of having it in the databases, there shouldn't be a need to add any other country than your own to the options. Thanks for the suggestion, I appreciate it.