BottleRocketStudios / iOS-Hyperspace

An extremely lightweight wrapper around URLSession to make working with APIs a breeze.

Apache License 2.0

47 stars 17 forks source link

Added Carthage Support #101

Closed ganttastic closed 5 years ago

ganttastic commented 5 years ago

Removed last remnants of Result framework. Removed BrightFutures project in the workspace as it's provided by carthage already built. Added carthage copy-frameworks scripts so it will pull in the correct carthage provided BrightFutures framework for each platform.

codecov-io commented 5 years ago

Codecov Report

Merging #101 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   94.62%   94.62%           
=======================================
  Files          46       46           
  Lines        1543     1543           
=======================================
  Hits         1460     1460           
  Misses         83       83

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b4b141...b963636. Read the comment docs.

ganttastic commented 5 years ago

@wmcginty / @tylermilner - Between the two travis builds all platforms build and pass. 😄 Plus the previous build passed and I only updated the README. Is there a way to rebuild? Or is it good to go?

wmcginty commented 5 years ago

There should be a way - if you go to the 'details' of the build - then the top right should have a 'restart build' button @ganttastic .

ganttastic commented 5 years ago

@wmcginty / @tylermilner We're passing now. Good for review.