Refinements to core functionality

[wmcginty]

I'm still cleaning up the tests and documentation but this is readier for review. If/when this is approved I can write up a migration guide and things like that, but I don't want to do that until I know what has been approved :D

• Request struct
• HTTP.Body type
• Some renaming (I feel like NetworkService and BackendService are very close to the same thing - open to discussion on that)
• DecodingFailureRepresentable is a refinement on NetworkFailureRepresentable
• More work in handling errors

[codecov-io]

Codecov Report

Merging #117 into master will decrease coverage by 0.05%. The diff coverage is 93.16%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   94.14%   94.08%   -0.06%     
==========================================
  Files          47       48       +1     
  Lines        1554     1404     -150     
==========================================
- Hits         1463     1321     -142     
+ Misses         91       83       -8     

Impacted Files	Coverage Δ
...cate Pinning/TrustValidatingTransportService.swift	0.00% <0.00%> (ø)
...ervice/Peripheral/NetworkActivityIndicatable.swift	100.00% <ø> (ø)
...perspace/Service/Peripheral/RecoveryStrategy.swift	100.00% <ø> (ø)
Tests/Helper/Mocks/MockCodableContainer.swift	100.00% <ø> (ø)
...ests/Helper/Mocks/MockNetworkSessionDataTask.swift	100.00% <ø> (ø)
Tests/Helper/Mocks/MockBackendService.swift	40.74% <37.50%> (ø)
Tests/Helper/Mocks/MockNetworkSession.swift	90.90% <50.00%> (-9.10%)	:arrow_down:
Sources/Hyperspace/HTTP/HTTP.swift	86.95% <53.84%> (-13.05%)	:arrow_down:
Tests/DecodingFailureTests.swift	80.00% <66.66%> (-20.00%)	:arrow_down:
...perspace/Extensions/Coding/Request+Decodable.swift	85.71% <85.71%> (ø)
... and 53 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ff9b7e6...4970c1f. Read the comment docs.

[codecov-commenter]

Codecov Report

Merging #117 into master will increase coverage by 0.56%. The diff coverage is 95.58%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   94.14%   94.70%   +0.56%     
==========================================
  Files          47       48       +1     
  Lines        1554     1455      -99     
==========================================
- Hits         1463     1378      -85     
+ Misses         91       77      -14     

Impacted Files	Coverage Δ
...cate Pinning/TrustValidatingTransportService.swift	0.00% <0.00%> (ø)
...ervice/Peripheral/NetworkActivityIndicatable.swift	100.00% <ø> (ø)
...perspace/Service/Peripheral/RecoveryStrategy.swift	100.00% <ø> (ø)
Tests/Helper/Mocks/MockCodableContainer.swift	100.00% <ø> (ø)
...ests/Helper/Mocks/MockNetworkSessionDataTask.swift	100.00% <ø> (ø)
Tests/Helper/Mocks/MockBackendService.swift	40.74% <37.50%> (ø)
Tests/Helper/Mocks/MockNetworkSession.swift	90.90% <50.00%> (-9.10%)	:arrow_down:
Tests/DecodingFailureTests.swift	81.25% <72.72%> (-18.75%)	:arrow_down:
...e/Request/Request.URLRequestCreationStrategy.swift	84.61% <84.61%> (ø)
Tests/HTTPTests.swift	92.85% <88.88%> (-1.12%)	:arrow_down:
... and 53 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ff9b7e6...ef9e419. Read the comment docs.

[tylermilner]

Also, I'm going to need you to fix all those Codebeat warnings. 😜

[wmcginty]

@tylermilner I was able to actually fix one, the rest I relaxed the rules. Otherwise we'd need to start creating sub-structs on Request.

[wmcginty]

Hadn't noticed the Travis failure - should be fixed now and ready to go barring additional feedback.