search

BottleRocketStudios / iOS-Hyperspace

An extremely lightweight wrapper around URLSession to make working with APIs a breeze.
Apache License 2.0
47 stars 17 forks source link

Feature/add mac os example #152

Closed andrew-winn-br closed 2 years ago

andrew-winn-br commented 2 years ago

Had to add Catalyst support because a Catalyst app uses the iOS/Catalyst version of a framework, not the macOS version. This should complete #6 Screen Shot 2022-02-03 at 11 54 36 AM Screen Shot 2022-02-03 at 11 54 17 AM

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

andrew-winn-br commented 2 years ago

Linter error is:

PackageDescription.SupportedPlatform:5:24: note: 'macCatalyst' was introduced in PackageDescription 5.5
PackageDescription.SupportedPlatform:33:27: note: 'v13' was introduced in PackageDescription 5.5

and the current package description for Hyperspace is 5.1. I think I can just remove the .macCatalyst(.v13) line from Package.Swift and it should still be fine. .macCatalyst was added as a specific platform for SPM in Xcode 13, but Catalyst was supported before that.

wmcginty commented 2 years ago

@andrew-winn-br I think we go ahead and upgrade the minimum tools version to 5.5, especially as this isn't going straight into a release we don't have to immediately worry about compatibility issues.