BottleRocketStudios / iOS-Hyperspace

An extremely lightweight wrapper around URLSession to make working with APIs a breeze.
Apache License 2.0
47 stars 17 forks source link

Error handlingv2 #38

Closed wmcginty closed 6 years ago

wmcginty commented 6 years ago

This should help address #28 .

Changes made:

This combination of changes allows for a few improvements:

Oh, and it changes the interface significantly enough that, if approved, we'll want to roll it up with some of the other proposed v2 changes.

codecov-io commented 6 years ago

Codecov Report

Merging #38 into release/2.0.0 will increase coverage by 0.14%. The diff coverage is 88.23%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/2.0.0      #38      +/-   ##
=================================================
+ Coverage          95.67%   95.82%   +0.14%     
=================================================
  Files                 27       26       -1     
  Lines                810      814       +4     
=================================================
+ Hits                 775      780       +5     
+ Misses                35       34       -1
Impacted Files Coverage Δ
...per/Test Defaults/NetworkRequestTestDefaults.swift 100% <ø> (ø) :arrow_up:
...space/Service/Network/NetworkServiceProtocol.swift 96.15% <ø> (ø) :arrow_up:
...erspace/Service/Backend/BackendServiceHelper.swift 100% <100%> (ø) :arrow_up:
Tests/BackendServiceTests.swift 98.64% <100%> (-0.02%) :arrow_down:
Sources/Hyperspace/Request/NetworkRequest.swift 100% <100%> (ø) :arrow_up:
...es/Hyperspace/Service/Backend/BackendService.swift 100% <100%> (ø) :arrow_up:
Tests/Helper/Mocks/MockBackendService.swift 60% <75%> (+60%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5540946...e586451. Read the comment docs.

wmcginty commented 6 years ago

@tylermilner I put a CHANGELOG.md entry together. I can look at creating a migration guide as we get closer to 2.0 release.

tylermilner commented 6 years ago

Looks good. Maybe just merge this into a release branch so that we're not touching master until we're ready to release version 2.0?

wmcginty commented 6 years ago

Switched over to merge back into release. Should be good to go now.