search

BottleRocketStudios / iOS-Hyperspace

An extremely lightweight wrapper around URLSession to make working with APIs a breeze.
Apache License 2.0
47 stars 17 forks source link

Mark Request.queryParameters as deprecated in v2 #61

Closed GrandLarseny closed 6 years ago

GrandLarseny commented 6 years ago

This change will alert developers that in 2.0 and beyond they should package query parameters in the url property.

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

codecov-io commented 6 years ago

Codecov Report

Merging #61 into master will decrease coverage by 0.16%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   96.39%   96.23%   -0.17%     
==========================================
  Files          33       33              
  Lines        1192     1194       +2     
==========================================
  Hits         1149     1149              
- Misses         43       45       +2
Impacted Files Coverage Δ
Sources/Hyperspace/Request/Request.swift 94.02% <0%> (-2.9%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 43162b3...4ea7ff0. Read the comment docs.