search

BottleRocketStudios / iOS-Hyperspace

An extremely lightweight wrapper around URLSession to make working with APIs a breeze.
Apache License 2.0
47 stars 17 forks source link

Removed queryParameters from Request extension #90

Closed wmcginty closed 5 years ago

wmcginty commented 5 years ago

Address #86

I left in the URLQueryParameterEncoder and extensions because while they are no longer part of the request, I think they're still helpful when generating URLs.

codecov-io commented 5 years ago

Codecov Report

Merging #90 into master will increase coverage by 0.12%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #90      +/-   ##
=========================================
+ Coverage   94.37%   94.5%   +0.12%     
=========================================
  Files          46      46              
  Lines        1512    1510       -2     
=========================================
  Hits         1427    1427              
+ Misses         85      83       -2
Impacted Files Coverage Δ
Sources/Hyperspace/Request/Request.swift 88.23% <ø> (+2.52%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04cf318...306d888. Read the comment docs.