search

BottleRocketStudios / iOS-UtiliKit

All the things you're tired of writing.
Apache License 2.0
23 stars 13 forks source link

Fix an issue with constraint insets #50

Closed wmcginty closed 5 years ago

wmcginty commented 5 years ago

Fix an issue where insets were being applied in the inverse direction when constraining a view to its superview.

tylermilner commented 5 years ago

Wow, that's a pretty big issue. Is there any way we could get a test written for this? I'm thinking that if we can just get one test written right now, it will pave the way for others to come in and add on more tests to make sure everything works correctly.

codecov-io commented 5 years ago

Codecov Report

Merging #50 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #50   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         180    204   +24     
=====================================
+ Hits          180    204   +24
Impacted Files Coverage Δ
Tests/UtiliKitTests.swift 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c171d57...5f37332. Read the comment docs.

wmcginty commented 5 years ago

Test and Changelog entry added.

wmcginty commented 5 years ago

Yea I was shocked as well - funnily enough it reared it's ugly head twice in two days on my project so I figured I'd better get it fixed. I'm hoping it doesn't break a whole lot of existing layouts using it the 'wrong' way.