BottleRocketStudios / iOS-UtiliKit

All the things you're tired of writing.
Apache License 2.0
23 stars 13 forks source link

Transition coordinator #63

Closed wmcginty closed 5 years ago

wmcginty commented 5 years ago

There's a lot going on here. Basically it allows you to use UIViewControllerInteractiveTransitioning and UIViewControllerTransitionCoordinator objects with the container.

I'm also thinking we might want to split this into it's own Pod as it's getting so large.

I'm still making tweaks to the protocols, but I wanted to get other eyes on it for more improvements.

codecov-io commented 5 years ago

Codecov Report

Merging #63 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #63   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         413    413           
=====================================
  Hits          413    413
Impacted Files Coverage Δ
Tests/ActiveLabelTests.swift 100% <ø> (ø) :arrow_up:
Tests/ContainerTests.swift 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 09154b5...563322e. Read the comment docs.

tylermilner commented 5 years ago

@ganttastic Agreed! I'm hoping that in the near future (possibly if we split this off into its own library), we provide several examples on how to use it. Everything from the most basic parent/child relationship to complex containers that animate between their children.

wmcginty commented 5 years ago

OK, changelog entry added and fixed some of the duplicate code issues and grammar mistakes @earlgaspard found. Let me know if there's anything else.

wmcginty commented 5 years ago

Going to give @earlgaspard and @ganttastic a chance to take another look after the last round of tweaks, otherwise I'll look to merge in later today / tomorrow.