BottleRocketStudios / iOS-UtiliKit

All the things you're tired of writing.

Apache License 2.0

23 stars 13 forks source link

Conform URL to ExpressibleByStringLiteral #66

Closed wmcginty closed 5 years ago

wmcginty commented 5 years ago

60

Figured I'd throw a PR up so we can see if this is worth adding. I have one main concern which is the possibility of multiple modules conforming URL to ExpressibleByStringLiteral and almost believe this is something that should be done on a project by project level.

Thoughts?

codecov-io commented 5 years ago

Codecov Report

Merging #66 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #66   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         413    413           
=====================================
  Hits          413    413

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a4f4dc...7559ae1. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #66 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #66   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         433    433           
=====================================
  Hits          433    433

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a16ce85...c5eae85. Read the comment docs.

wmcginty commented 5 years ago

@tylermilner Looks like I needed to fix a conflict. Can you give this one last look over before merging?