search

BottleRocketStudios / iOS-UtiliKit

All the things you're tired of writing.
Apache License 2.0
23 stars 13 forks source link

Container - completion block in transitionToController no longer called #75

Closed earlgaspard closed 4 years ago

earlgaspard commented 5 years ago

While using 1.6.0, I discovered that the completion block in transitionToController was no longer being called. My work around was to implement the delegate callback: containerViewController(_ container: ContainerViewController, didFinishTransitioningFrom

containerViewController.transitionToController(for: child) { _ in
   // does not get hit
}
wmcginty commented 5 years ago

@earlgaspard If you switch to use #76 does it fix your issue?

wmcginty commented 5 years ago

Should be addressed by #76. @earlgaspard can you confirm and close?

earlgaspard commented 5 years ago

I can check #76 later today and see if it works.

earlgaspard commented 5 years ago

Well, it does not look like it is going to be today. Sometime soon.

wmcginty commented 4 years ago

I have not heard this happening, going to close.