search

BottleRocketStudios / iOS-UtiliKit

All the things you're tired of writing.
Apache License 2.0
23 stars 13 forks source link

Remove source or destination view from container after animation #81

Closed dmilinski closed 5 years ago

dmilinski commented 5 years ago

Talked to Will about this one and we felt it made sense to have the container do this, since it has the rest of the VC containment logic.

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

codecov-io commented 5 years ago

Codecov Report

Merging #81 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #81   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         433    433           
=====================================
  Hits          433    433

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6728732...1b18aaa. Read the comment docs.

wmcginty commented 5 years ago

Either this has changed in iOS 13 or the view debugger in Xcode 11 is a ton better. Either way, this looks good to me!