Closed vutran closed 7 years ago
@vutran will we need to update bottr-cli
to run node with ES6 support ?
@jcampbell05 Not necessarily. I believe this will work on node v4+. I guess what we need to determine is whether to support Node v0.12 or lower since those versions doesn't support any ES6 features.
My thoughts is to support LTS up to most current version which is v4-v6+ for all packages. What are your thoughts? (side note: we can setup travis and specify the target versions for tests).
@vutran I don't mind, I don't have much knowledge to know which version most people use. So if v4 is the lowest LTS version then lets use that!
You okay to set that up ?
@jcampbell05 Yeah, let's keep this PR open. I'll try to do some cleanup this weekend. (trying to balance time with my own projects atm)
@vutran Could I merge this in so I can help you out ?
@jcampbell05 Sure, may need to rebase due to the merge conflicts though. I haven't had the time to clean this up yet since I've been busy lately transitioning to a new job.
@vutran No worries :) there as been quite alot of changes thats why I'm thinking it will be easier. I'll handle the merges :)
@jcampbell05 I had to rebase the branch since some of the underlying API of the client changed recently.
@vutran awesome I'll merge this so we can continue working on it
This PR adds a base interface class and migrates existing clients to utilize ES2015 classes. This will make it easier for people to write clients.
Custom configurations per bot is moved to an
init()
method which gets called upon instantiation but the public API should still be the same.Open for ideas if anything can be made better or needs to change.