fix eslint configs - Githubissues

Bottr-js / Bottr

🤖 The world's simplest framework for creating Bots

http://bottr.co

MIT License

936 stars 86 forks source link

fix eslint configs #57

Closed vutran closed 7 years ago

vutran commented 7 years ago

Updates eslint configs:

Merge options specified in .eslintrc.json into package.json
Lint only these directories: __mocks__, __tests__, lib, and index.js

tanhauhau commented 7 years ago

Seems like you are removing all the eslint options from package.json as well as .eslintrc.json. Why not consolidate all of them to .eslintrc.json?

vutran commented 7 years ago

The airbnb-base eslint config should already set the rules seen in package.json so there's no need to redeclare those rules.

coveralls commented 7 years ago

Coverage remained the same at 86.854% when pulling faa22edfa8487b781b0791f0df01dc22ff7bf3a2 on vutran:fix-lint-directories into 4787b918b318b9a56c27ebb53b971fb1a0e08681 on Bottr-js:master.

tanhauhau commented 7 years ago

I noticed there's eslint installed as dependencies in package.json, it should be only installed as dev-dependencies, guess you can remove it along in this PR as well?

coveralls commented 7 years ago

Coverage remained the same at 86.854% when pulling 8dcf7a25d8ee1ee94d695ce8fbc7143ffdc6e7c7 on vutran:fix-lint-directories into 4787b918b318b9a56c27ebb53b971fb1a0e08681 on Bottr-js:master.