Closed drewbotts closed 1 month ago
[x] "sample" directory to "botts" in "src/main/..."
[x] change text to category: https://github.com/Botts-Innovative-Research/osh-oakridge-modules/blob/a35d3d8c61fb1d15a987d89aab9b0f8db8ceff3f/sensors/sensorhub-driver-wadwaz-1/src/main/java/com/sample/impl/sensor/wadwaz1/EntryAlarmOutput.java#L77C43-L77C43 Text is not wrong but Category would be a better choice since it has limited set of values that are allowed (good job on using allowed values)
[x] Remove location from Alarm Outputs since we already have a Location output for the system
[x] Add location input to config: https://github.com/Botts-Innovative-Research/osh-oakridge-modules/blob/a35d3d8c61fb1d15a987d89aab9b0f8db8ceff3f/sensors/sensorhub-driver-rapiscan/src/main/java/com/botts/impl/sensor/rapiscan/RapiscanConfig.java
[x] Set Location data like this: https://github.com/Botts-Innovative-Research/osh-oakridge-modules/blob/a35d3d8c61fb1d15a987d89aab9b0f8db8ceff3f/sensors/sensorhub-driver-rapiscan/src/main/java/com/botts/impl/sensor/rapiscan/RapiscanSensor.java#L86C1-L87C1
- [ ] We may be able to combine some of these outputs together
[x] "sample" directory to "botts" in "src/main/..."
[x] change text to category: https://github.com/Botts-Innovative-Research/osh-oakridge-modules/blob/a35d3d8c61fb1d15a987d89aab9b0f8db8ceff3f/sensors/sensorhub-driver-wadwaz-1/src/main/java/com/sample/impl/sensor/wadwaz1/EntryAlarmOutput.java#L77C43-L77C43 Text is not wrong but Category would be a better choice since it has limited set of values that are allowed (good job on using allowed values)
[x] Remove location from Alarm Outputs since we already have a Location output for the system
[x] Add location input to config: https://github.com/Botts-Innovative-Research/osh-oakridge-modules/blob/a35d3d8c61fb1d15a987d89aab9b0f8db8ceff3f/sensors/sensorhub-driver-rapiscan/src/main/java/com/botts/impl/sensor/rapiscan/RapiscanConfig.java
[x] Set Location data like this: https://github.com/Botts-Innovative-Research/osh-oakridge-modules/blob/a35d3d8c61fb1d15a987d89aab9b0f8db8ceff3f/sensors/sensorhub-driver-rapiscan/src/main/java/com/botts/impl/sensor/rapiscan/RapiscanSensor.java#L86C1-L87C1
- [ ] We may be able to combine some of these outputs together