search

BouchardLab / nsds_lab_to_nwb

Python package to convert NSDS Lab data to NWB files.
https://nsds-lab-to-nwb.readthedocs.io/en/latest/
0 stars 4 forks source link

Adding simple and fancy tdt to nwb electrical series converter methods #1

Closed jthermiz closed 3 years ago

jthermiz commented 3 years ago

Adding simple and fancy tdt to nwb electrical series converter methods. Simple works, but fancy (iterative write) does NOT. I'm getting a broadcast error on the iterative write that I'm stumped on and could use some help. In the short term, I don't think there's a need for an iterative write converter, so we could come back to this later...

jihyunbak commented 3 years ago

Thanks for this @jthermiz! It would be great if this could be fit into the updated version of TdtManager. Please take a look and let me know if you have any questions.

Perhaps we could keep two (simple and fancy) versions of the TdtManager.__extract_from_tdt_files() method? Feel free to rename that method as it is just a placeholder. Also feel free to introduce any new structure as long as it fits the originator-manager scheme, or let's discuss if you want to make more major changes!

JesseLivezey commented 3 years ago

@jthermiz let us know when you're ready for feedback. i have some ideas about how to organize this and add some tests

jthermiz commented 3 years ago

@jihyunbak and @JesseLivezey I implemented TdtManager.__extract_from_tdt_files() using the simple approach and left code in there as a starting point for iterative writing to an NWB. To implement iterative write, I think we'd need to rework the architecture since the tdt extraction method would return a data iterator not the data itself. But let's discuss live. Perhaps we should have a weekly or bi-weekly meeting about lab software dev?

jthermiz commented 3 years ago

Closing PR bc #7 takes care of this