Closed jthermiz closed 3 years ago
@jihyunbak Let me know what you think
Looks good to me. Thanks @jthermiz !!
I like the idea of moving the use_htk
switch to the NWBBuilder class level. Just to finish the housekeeping, it would be great to also update the build() method in NWBBuilder such that
self.use_htk
instead of the method input argument use_htk
use_htk
is equal to self.use_htk
, and raise an error if not. <— Please feel free to skip this if you feel it's not necessary! Maybe we shouldn't worry about the API change at this stage, and just drop the use_htk
input to the build() method.Quick Q: By the "past NWB" do you mean the NWB files that were created using MARS, i.e., the NWB files that existed before we developed this repository? (I guess so)
@jihyunbak I removed use_htk from NWBBuilder.build(), which makes total sense. "past NWB" refers to the NWB that was in the December hackathon folder that @VBaratham put together. Presumably that was created using MARS.
This addresses issue #21 HTK --> NWB now works. Previously,
NWBBuilder
calledtdt_orignator
even though htk data was passed. Created ause_htk
optional arg to stop that from happening. Wrote test casetest_build_nwb_case3_htk
and compared new nwb to past nwb and they looked the same across various spot checks.