BouchardLab / nsds_lab_to_nwb

Python package to convert NSDS Lab data to NWB files.
https://nsds-lab-to-nwb.readthedocs.io/en/latest/
0 stars 4 forks source link

Test htk #22

Closed jthermiz closed 3 years ago

jthermiz commented 3 years ago

This addresses issue #21 HTK --> NWB now works. Previously, NWBBuilder called tdt_orignator even though htk data was passed. Created a use_htk optional arg to stop that from happening. Wrote test case test_build_nwb_case3_htk and compared new nwb to past nwb and they looked the same across various spot checks.

jthermiz commented 3 years ago

@jihyunbak Let me know what you think

jihyunbak commented 3 years ago

Looks good to me. Thanks @jthermiz !!

I like the idea of moving the use_htk switch to the NWBBuilder class level. Just to finish the housekeeping, it would be great to also update the build() method in NWBBuilder such that

Quick Q: By the "past NWB" do you mean the NWB files that were created using MARS, i.e., the NWB files that existed before we developed this repository? (I guess so)

jthermiz commented 3 years ago

@jihyunbak I removed use_htk from NWBBuilder.build(), which makes total sense. "past NWB" refers to the NWB that was in the December hackathon folder that @VBaratham put together. Presumably that was created using MARS.