BouchardLab / nsds_lab_to_nwb

Python package to convert NSDS Lab data to NWB files.
https://nsds-lab-to-nwb.readthedocs.io/en/latest/
0 stars 4 forks source link

process different stimuli types #85

Closed jihyunbak closed 3 years ago

jihyunbak commented 3 years ago

Description and related issues

Now successfully processes (tone, tone150, timit, dmr, nan, wn2) without neural data resampling; tone_diagnostic needs additional input in list_of_stimuli.yaml.

Includes Jesse's commits (manual rebase) from PR #69 .

Should be reviewed at the same time with a PR to the metadata library repo (below)

Partially addresses issues #71 and #72 .

Changes outside this repo:

Status:

Test blocks that were failing before this PR:

# --------------------------------------------------------------
# new test blocks: RVG16_{B02, B04, B05, B06, B07, B08, B09, B10}
#     - B02, B04, B05: tone_diagnostic (no associated files in list_of_stimuli.yaml)
#     - B06: Tone                                <<<<<<< now passes with resample_data=False
#     - B07: Tone150                             <<<<<<< now passes with resample_data=False
#     - B08: TIMIT                               <<<<<<< now passes with resample_data=False
#     - B09: stimulus 'nan'                      <<<<<<< now passes (handled by Stopping gracefully)
#     - B10: dmr                                 <<<<<<< now passes (handled by not tokenizing)
# legacy test block: R56_B10: metadata yaml not found in data_path
# ———————————————————————————————

Checklist:

jihyunbak commented 3 years ago

Thanks for the very timely review @JesseLivezey ! Okay, I think this PR achieved some of my goals, in that the repo now allows us to process stimuli other than wn2. I'll merge now & let's handle those issues separately!