Closed jihyunbak closed 3 years ago
Thanks for the very timely review @JesseLivezey ! Okay, I think this PR achieved some of my goals, in that the repo now allows us to process stimuli other than wn2. I'll merge now & let's handle those issues separately!
Description and related issues
Now successfully processes (tone, tone150, timit, dmr, nan, wn2) without neural data resampling; tone_diagnostic needs additional input in
list_of_stimuli.yaml
.Includes Jesse's commits (manual rebase) from PR #69 .
Should be reviewed at the same time with a PR to the metadata library repo (below)
Partially addresses issues #71 and #72 .
Changes outside this repo:
Metadata library — co-developing with this PR in the metadata repo
Did not pull this PR in the catscan metadata repo
/clusterfs/NSDS_data/NSDSLab-NWB-metadata/
Stimulus library
/clusterfs/NSDS_data/stimuli/Tone/Tone.stimVls.mat
(copied frommars.configs
)Status:
Test blocks that were failing before this PR:
Checklist:
pytest --basetemp=tmp -sv -n 8 tests
on catscan from the root directorydocs/source
has been updated for any added, moved, or removed files - N/Amake clean & make html
from thedocs
folderflake8 nsds_lab_to_nwb tests
from the root directory