Closed jihyunbak closed 3 years ago
Thanks for the reviews @JesseLivezey ! Agree with both suggestions (error from BaseTokenizer, logger warning from WNTokenizer) — I was simply keeping the legacy behavior in both cases, but I'll change those before I merge!
Description and related issues
Cleanup work for the trialization/tokenization pipeline.
MarkTokenizer
toTrialsManager
, and let this handle thenwb_content.add_trial(…)
operations. TheTrialsManager
uses the Tokenizer classes to construct a list of trials, but the Tokenizer classes now do not work directly on the nwb_content.BaseTokenizer
(renamed fromStimulusTokenizer
). Refactor features into separate methods.wn2.yaml
stimulus metadata. No justification for this value 0.1. Empirically this leads to a successful identification of all 60 stim onsets in the test blockRVG16_B01
.~ —————— EDIT: this is now commented out, so the behavior is unchanged.Didn't resolve the number of stim onset mismatch issues (for the WN and TIMIT tokenizers), but set the stage up…
Closes #(issue number)
Checklist:
pytest --basetemp=tmp -sv -n 8 tests
on catscan from the root directorydocs/source
has been updated for any added, moved, or removed filesmake clean & make html
from thedocs
folderflake8 nsds_lab_to_nwb tests
from the root directory