BouchardLab / process_ecog

1 stars 6 forks source link

Added function `preprocess_data()` to be imported from `ecog.signal_processing` #4

Closed luiztauffer closed 5 years ago

luiztauffer commented 5 years ago
JesseLivezey commented 5 years ago

@luiztauffer @bendichter FYI, we're not planning on maintaining anything in this repo. It's likely that in a few weeks we'll make the current version of our preprocessing code public, which was initially based on the code here. Were you looking to build substantially on this code?

luiztauffer commented 5 years ago

Hi @JesseLivezey thanks for the heads up! We’re altering the current process_ecog for two main reasons: 1 – make the preprocessing function directly usable by an ECoG visualization project. 2 – make it store the results in NWB files

Would you mind sharing what will be the main changes with the new software? =)

JesseLivezey commented 5 years ago

It might be easier to just copy the preprocessing functions and modify them in your repo. I could also make a different branch and merge them here (I'm using the docker branch for something specific).

The low-level changes to the new version are mostly for operating on arrays that are too large to process in memory all at once. Otherwise, they are the same. The high-level changes are to make the later stages of processing NWB compatible (and also somewhat specific to our lab).

JesseLivezey commented 5 years ago

I can't commit to managing anything in this repo, so it might be better for the other project not to depend on anything here.