BouchardLab / process_nwb

Functions for preprocessing timeseries data stored in the NWB format

https://process-nwb.readthedocs.io/en/latest/

4 stars 6 forks source link

Add tutorial for process_nwb #28

Closed hlillemark closed 3 years ago

hlillemark commented 3 years ago

Changed tutorial python file to be formatted compatible with sphinx gallery, and added sphinx gallery configurations.

hlillemark commented 3 years ago

Not sure why the test is failing saying that it could not import matplotlib

hlillemark commented 3 years ago

Thanks for the review, @JesseLivezey, I'll fix all the syntax and stuff and push a new commit with those changes soon. I was wondering about why it doesn't pass the Travis CI tests, however. I reverted my conf.py file so that it matches the one you put in master, and it has an error with not being able to import matplotlib (and I would assume every other library) in the venv that is created when building the tutorial docs, is there a way to fix this?

JesseLivezey commented 3 years ago

@hlillemark I think you'll need to add matplotlib in 2 places.

First one is at the end of this conda install ... line https://github.com/BouchardLab/process_nwb/blob/0ce40a9c9d98222038605dcd9e38580dc0b3c20b/.travis.yml#L17

and the second one is on a new line (you can put it after scipy) here https://github.com/BouchardLab/process_nwb/blob/0ce40a9c9d98222038605dcd9e38580dc0b3c20b/environment-dev.yml#L3

codecov[bot] commented 3 years ago

Codecov Report

Merging #28 (02e8663) into master (0ce40a9) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   70.86%   70.86%           
=======================================
  Files           7        7           
  Lines         254      254           
=======================================
  Hits          180      180           
  Misses         74       74

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ce40a9...02e8663. Read the comment docs.

hlillemark commented 3 years ago

All the commits are from rebasing, not sure why it did that, but the actual changes are as intended

hlillemark commented 3 years ago

Fixed everything with git, formatting, testing, and the tutorial itself. Should be good after a final review.