Bouke / HAP

Swift implementation of the Homekit Accessory Protocol
https://boukehaarsma.nl/HAP/
MIT License
366 stars 50 forks source link

Maintain instance ids assignments between restarts #49

Closed Bouke closed 4 years ago

Bouke commented 6 years ago

From the HAP specification 2.6.1.2:

After a firmware update services and characteristics types that remain unchanged must retain their previous instance ids, newly added services and characteristics must not reuse instance ids from services and characteristics that were removed in the firmware update.

We currently reassign instance ids.

gbrooker commented 5 years ago

This should be fixed with the addition of the persistent configuration

Bouke commented 5 years ago

So currently, changing the ordering of services or acessories, would change the instance identifiers. As we already have some persistence in place, I think this can be fixed by extending on that.

gbrooker commented 4 years ago

This should be closed now