Stop using Box<> / ObjectIdentifier for subscribers

Bouke / HAP

Swift implementation of the Homekit Accessory Protocol

https://boukehaarsma.nl/HAP/

MIT License

366 stars 50 forks source link

Stop using Box<> / ObjectIdentifier for subscribers #5

Closed Bouke closed 5 years ago

Bouke commented 7 years ago

I don't like the way this is implemented as a result of Characteristic being a protocol, therefore not being able to participate in heterogeneous collections. Possible alternatives:

Store subscribers on the characteristic themselves -- however I don't like having the characteristics keeping a reference to the connections
Some other way of identifying characteristics, we must know which connections subscribed to which characteristics

Bouke commented 5 years ago

Box is removed in #68. ObjectIdentifier is fine I guess.