search

Bouke / HAP

Swift implementation of the Homekit Accessory Protocol
https://boukehaarsma.nl/HAP/
MIT License
366 stars 50 forks source link

Update for final release of macOS 10.14.4 and iOS 12.2 #82

Closed gbrooker closed 5 years ago

gbrooker commented 5 years ago

Update for final release of macOS 10.14.4 and iOS 12.2, which include support for the Television accessory.

gbrooker commented 5 years ago

This is not compiling because I included a minor change in hap-server which is required for swift 4.2. Is it now possible to change the build settings to swift 4.2 or are there still issues on linux meaning you still need to stick to swift 4.1 ? Xcode 10.2 now only allows builds for swift 4, 4.2 and 5.0

Bouke commented 5 years ago

I'm using Swift 4.2 now on my Raspberry, so I'm fine with dropping 4.1. đź‘Ť It would be great if we could explicitly target 4.2 and 5.0 from now on.

Bouke commented 5 years ago

FYI: I've started a branch to see what's needed to support Swift 5. See also #84.

gbrooker commented 5 years ago

So strange, it seems osx and linux swift 4.2 do not have the same definition of RunLoop

Bouke commented 5 years ago

Yeah that’s the big downside to Swift Foundation, it’s functionality wise not at par with the OSX counterpart and API wise also lagging behind on changes in the OSX counterpart.

Op 31 mrt. 2019 om 12:22 heeft Guy Brooker notifications@github.com het volgende geschreven:

So strange, it seems osx and linux swift 4.2 do not have the same definition of RunLoop

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Bouke commented 5 years ago

I've merged Swift 5 support, including a fix for the Foundation naming conflict.

gbrooker commented 5 years ago

This should now be ready to be merged