BoukeHaarsma23 / WattmanGTK

A Wattman-like GTK3+ GUI
GNU General Public License v2.0
374 stars 61 forks source link

Wrong capitalization of Mhz when reading pp_od_clk_voltage #2

Closed urbenlegend closed 5 years ago

urbenlegend commented 5 years ago

So the app expects MHz in places where sysfs is returning Mhz

cat pp_od_clk_voltage gives me

OD_SCLK:
0:        852Mhz        800mV
1:        991Mhz        900mV
2:       1084Mhz        950mV
3:       1138Mhz       1000mV
4:       1200Mhz       1050mV
5:       1401Mhz       1100mV
6:       1576Mhz       1150mV
7:       1663Mhz       1200mV
OD_MCLK:
0:        167Mhz        800mV
1:        500Mhz        800mV
2:        800Mhz        950mV
3:        945Mhz       1100mV
OD_RANGE:
SCLK:     852MHz       2400MHz
MCLK:     167MHz       1500MHz
VDDC:     800mV        1200mV

but GPU.getStates is looking for MHz when reading OD_SCLK and OD_MCLK. This causes OD_RANGE parsing to fail later on.

BoukeHaarsma23 commented 5 years ago

Please see: 47fbba619981b327c6c5bb8f9bb3f88771913d02

does this fix it for you?

urbenlegend commented 5 years ago

This works! Thanks for the quick fix!