Boulder-Cryogenic-Quantum-Testbed / scresonators

Data analysis code for cryogenic resonator measurement
MIT License
30 stars 25 forks source link

Future error with Python 3.10 and onwards #127

Closed fponce004 closed 1 year ago

fponce004 commented 2 years ago

Hi, so in Python 3.10 collections does not contain either of Sequence or MutableMapping this now has to become: collections.abc.Sequence and collections.abc.MutableMapping they are located in skrf util.py line 281 and 379 respectfully.

nmaterise commented 2 years ago

Thanks @fponce004 , we will look into this further and try to address this issue as soon as possible

crmcrae commented 2 years ago

Has this been addressed?

nmaterise commented 2 years ago

I haven't looked into it, I will investigate where the code calls skrf. I think Keegan added it some time ago when he added the circle normalization. We may not need it (scikit-rf) anymore.

nmaterise commented 1 year ago

Resolved by #154