search

Boulder-Cryogenic-Quantum-Testbed / scresonators

Data analysis code for cryogenic resonator measurement
MIT License
30 stars 25 forks source link

fscale argument passing #137

Closed crmcrae closed 2 years ago

crmcrae commented 2 years ago

fscale can be passed in two ways: through Resonator.from_file and VNA_sweep.from_file. fscale passed through Resonator.from_file overwrites Resonator.fscale. We need to determine the best way to pass fscale without the risk of it being overwritten elsewhere.

nickkprice commented 2 years ago

I think I see what you mean. For the use case of someone that has multiple files to parse through that all want the same fscale, but without defining the fscale with every from_file call?

nmaterise commented 2 years ago

I think we were also concerned about the general usage of fscale from a user interface point of view. I was wondering if you had intended fscale to be a member of the Resonator class or a stand-alone argument of Resonator.from_file() that wraps VNA_sweep.from_file()

nickkprice commented 2 years ago

I was generally keeping most arguments as attributes of Resonator since that's the interface with the rest of the code, not knowing that fscale was something only relevant to initial reading-in of data. With that in mind, I'll change it to a stand-along argument for the from_file calls, and remove it as a Resonator attribute.

nmaterise commented 2 years ago

This was fixed by #138.