search

Boulder-Cryogenic-Quantum-Testbed / scresonators

Data analysis code for cryogenic resonator measurement
MIT License
28 stars 24 forks source link

Fix linear normalization preprocess bug #191

Closed nmaterise closed 9 months ago

nmaterise commented 9 months ago

This is a quick fix to make 'linear' work We should investigate why I needed to comment The lines out that were a problem

scottito commented 9 months ago

Interesting. I agree, I will need to take a closer look at those lines. Did you make sure commenting them out does not affect circle preprocessing? @nmaterise

nmaterise commented 9 months ago

The block that I commented out is separate from the circle fit option. I think it applies a circle fit normalization to data that linear normalization failed to work. This doesn't make sense for at least one use case where the linear normalization worked, but the code continued to attempt to perform a circle normalization.

scottito commented 9 months ago

Got it.