search

Boulder-Cryogenic-Quantum-Testbed / scresonators

Data analysis code for cryogenic resonator measurement
MIT License
28 stars 24 forks source link

Get tests passing #196

Closed scottito closed 9 months ago

scottito commented 9 months ago

@nmaterise I had to comment Mattis-Bardeen from requirements.txt because it cannot be pip installed by symbol. I disabled warnings for pylint which may change in the future but currently flags almost every line with strict pep-8 practices. Numpy isclose works to compare expected values of fit.

I also moved minimum working example to root directory and included instructions on how to use in readme.

nmaterise commented 9 months ago

@nmaterise I had to comment Mattis-Bardeen from requirements.txt because it cannot be pip installed by symbol. I disabled warnings for pylint which may change in the future but currently flags almost every line with strict pep-8 practices. Numpy isclose works to compare expected values of fit.

I also moved minimum working example to root directory and included instructions on how to use in readme.

That all sounds good. I think we will want to pull Mattis-Bardeen from its github. I think my code used pip from the cloned version of the code, and that's why it ended up in the requirements.txt file. If you know how to add github repositories to requirements.txt, I think it will fix that problem. Everything else looks good.