Closed rabutler-usbr closed 4 years ago
If the period is eocy or Jan, should there be an error if the summary is set to sum or anything else really?
eocy
Jan
sum
Ex:
zz <- data.frame( file = "KeySlots.rdf", slot = "x.y", period = "asis", summary = "sum", eval = NA, t_s = NA, variable = "this", stringsAsFactors = FALSE ) rwd_agg(zz)
returns the following error:
Error: If the period is specified as 'asis', then the summary must be NA.
period
summary
NA
But
zz <- data.frame( file = "KeySlots.rdf", slot = "x.y", period = "eocy", summary = "sum", eval = NA, t_s = NA, variable = "this", stringsAsFactors = FALSE ) rwd_agg(zz)
does not return an error.
Maybe it should return an error for eocy because that would go all the way to a single timestep regardless of timestep of the model, while Jan would select 31 days in a daily model that could then be summarized with sum, etc.
Man page says that it should error for eocy. Will fix this.
If the period is
eocy
orJan
, should there be an error if the summary is set tosum
or anything else really?Ex:
returns the following error:
But
does not return an error.
Maybe it should return an error for
eocy
because that would go all the way to a single timestep regardless of timestep of the model, whileJan
would select 31 days in a daily model that could then be summarized withsum
, etc.