BoulderCodeHub / RWDataPlyr

R package to read and manipulate data from RiverWareTM
3 stars 5 forks source link

Make aggregation methods safe for thresholds between 0 and 1 #14

Closed rabutler closed 7 years ago

rabutler commented 8 years ago

In getDataFromRdf.R, the aggregation methods that check to see if the values are greater/less than a threshold (e.g., EOCYLTE) will not work if the threshold is between 0 and 1.

I don't think this is an issue for the typical uses of these agg methods, but they should work for any values, or at least return a warning. One potential solution is to create a boolean matrix and compare to the original data instead of using 1s and 0s.