XTS Capabilities and Functions: Issue #13

BoulderCodeHub / RWDataPlyr

R package to read and manipulate data from RiverWareTM

3 stars 5 forks source link

XTS Capabilities and Functions: Issue #13 #16

Closed tjrocha closed 7 years ago

tjrocha commented 8 years ago

This pull request addresses issue #13.

rabutler commented 8 years ago

Thanks @tjrocha! I will take a look at this as soon as I can. 1 initial request thought: please add the zoo and xts packages to the imports section of the DESCRIPTION file in this PR.

rabutler commented 8 years ago

@tjrocha Regarding the comment on names:

getMinAnnValue, getMaxAnnVAlue, and sumMonths2Annual currently exist. However, they are expecting a matrix and can't really take advantage of the functions you are using. What if we added a check in those functions to see if the value being passed in is an xts ojbect and if so, use your logic, otherwise use the existing logic?

If you are ok with either of these approaches, I can go ahead and make those changes.

rabutler commented 8 years ago

@tjrocha will you please cancel this PR and request a PR into the rabutler:dev branch?