BoulderCodeHub / RWDataPlyr

R package to read and manipulate data from RiverWareTM
3 stars 5 forks source link

AppVeyor builds fail due to issue with read.rdf() #63

Closed rabutler closed 6 years ago

rabutler commented 6 years ago

The builds fail due to tests and examples that use read.rdf().

The example rdf files are originally from RiverWare which marks line endings by CRLF. The files that are included in the package are marked by LF.

read.rdf() uses readLines() and seek() for various advances of the connection; it is noted that seek() can be buggy on Windows and it is not suggested that it be used on Windows.

Solution: We don't really use read.rdf() anymore because read.rdf2() is faster. Additionally, it relies on data.table::fread() which can handle any EOL characters, so this is not an issue for it.

Go ahead and delete read.rdf() and its helper functions. They had a nice run.