search

BounceTribe / bt-api

0 stars 0 forks source link

Is mjml actually being used? #1

Closed JakeIwen closed 7 years ago

JakeIwen commented 7 years ago

https://github.com/BounceTribe/bt-api/blob/master/src/emails/feedbackReceived.js https://github.com/BounceTribe/bt-api/blob/master/src/emails/friendRequestAccepted.js

mjml is defined at the beginning of the page and never referenced nor exported. It looks like a HTML conversion of the mjml may be getting used instead.

Is this intended?

carlpeaslee commented 7 years ago

It is not being used. And it shouldn’t be imported. Probably there should instead be a script or something somewhere that takes the original and converts it and that could get run whenever we wanted. On Wed, Oct 11, 2017 at 12:32 PM Jake Iwen notifications@github.com wrote:

https://github.com/BounceTribe/bt-api/blob/master/src/emails/feedbackReceived.js

https://github.com/BounceTribe/bt-api/blob/master/src/emails/friendRequestAccepted.js

mjml is defined at the beginning of the page and never referenced nor exported. It looks like a HTML conversion of the mjml may be getting used instead.

Is this intended?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BounceTribe/bt-api/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AOhs3p9GWr-cASf3gKsPxCujX1yxY6hVks5srDbRgaJpZM4P03kh .

JakeIwen commented 7 years ago

Sounds good, thank you. Also, is this ever run locally for testing? Want to make sure things work before pushing. There is nothing in .gitignore suggesting that ENV variables have been set up locally.

I am having trouble tracing the stack for sending an email. For example: I can see that an email with subject "Welcome to bouncetribe" was sent out yesterday via the Mailgun dashboard. I cannot find the words "Welcome to Bouncetribe" (within this context) anywhere in either BT repo. Where is this being sourced? How can I trace the "welcome to bouncetribe" email example?

carlpeaslee commented 7 years ago

I don’t it ever is run locally— which isn’t ideal. Would probably be helpful to set up that capability. On Thu, Oct 12, 2017 at 6:21 AM Jake Iwen notifications@github.com wrote:

Sounds good, thank you. Also, is this ever run locally for testing? Want to make sure things work before pushing. There is nothing in .gitignore suggesting that ENV variables have been set up locally.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/BounceTribe/bt-api/issues/1#issuecomment-335952328, or mute the thread https://github.com/notifications/unsubscribe-auth/AOhs3ql-8huXM9eF603XqP2NXk_XhxuIks5srTFggaJpZM4P03kh .

JakeIwen commented 7 years ago

Also @carlpeaslee could I get added to this repo for write access?