Bouni / kicad-jlcpcb-tools

Plugin to generate BOM + CPL files for JLCPCB, assigning LCSC part numbers directly from the plugin, query the JLCPCB parts database, lookup datasheets and much more.
MIT License
1.15k stars 105 forks source link

LCSC attributes not applied to subsheets #341

Open thirtythreeforty opened 1 year ago

thirtythreeforty commented 1 year ago

Describe the bug With a hierarchical schematic, LCSC attributes are only added to the selected sheet, not sub-sheets.

To Reproduce Steps to reproduce the behavior:

  1. Create a sheet with a subsheet. Add a part to this subsheet.
  2. Assign a component number in jlcpcb-tools.
  3. Export the LCSC part numbers to the main sheet.

Expected behavior I expect all the LCSC part numbers to be applied to the selected .kicad_sch, and all subsheets, recursively, referenced by that sheet.

KiCad Version

Application: KiCad x86_64 on x86_64

Version: 7.0.6, release build

Libraries:
    wxWidgets 3.2.2
    FreeType 2.13.1
    HarfBuzz 7.3.0
    FontConfig 2.14.2
    libcurl/8.1.2 OpenSSL/3.1.1 zlib/1.2.13 brotli/1.0.9 zstd/1.5.5 libidn2/2.3.4 libpsl/0.21.2 (+libidn2/2.3.4) libssh2/1.11.0 nghttp2/1.55.1

Platform: EndeavourOS Linux, 64 bit, Little endian, wxGTK, KDE, x11

Build Info:
    Date: Jul  7 2023 09:07:45
    wxWidgets: 3.2.2 (wchar_t,wx containers) GTK+ 3.24
    Boost: 1.81.0
    OCC: 7.6.3
    Curl: 8.1.2
    ngspice: 40
    Compiler: GCC 13.1.1 with C++ ABI 1018

Build settings:
    KICAD_USE_EGL=ON
    KICAD_SPICE=ON
Bouni commented 1 year ago

@computergeek1507 Please take a look if this is easy to fix ...

Bouni commented 1 year ago

@thirtythreeforty I hope for real API support for schematics in Kicad V8 (V7.99) soon so this gets a lot better to handle. At the moment its kind of hacky 😅