search

Bouni / kicad-jlcpcb-tools

Plugin to generate BOM + CPL files for JLCPCB, assigning LCSC part numbers directly from the plugin, query the JLCPCB parts database, lookup datasheets and much more.
MIT License
1.13k stars 102 forks source link

rotation mapping automatically flip the rotation sign if the layer is top or bottom #374

Open gionag opened 11 months ago

gionag commented 11 months ago

If i save a mapping for certain package on the top layer, when i use the same package on the opposite layer, also the sign of the rotation should change.

Should internally adapt the sign if the component is placed on top or bottom

Maybe is a recent change on jlcpcb portal

Bouni commented 10 months ago

Can you give an example so that I can test it?

dzid26 commented 8 months ago

I came across the same (?) problem on my double sided board.

To my surprise the correction "sign" switching was already implemented here:

https://github.com/Bouni/kicad-jlcpcb-tools/blob/b764df8f686480bc7b494119e9beed2e891d7c8c/fabrication.py#L94-L112

After removing this condition (i.e. always True), I've gotten correct results on both sides. Strange.

dzid26 commented 8 months ago

I was able to reproduce the issue with standard kicad library footprint.

Example footprint is TO-277A with C895438 - rotation 90deg. Top: image Bottom: image

https://github.com/Springer-Electronics/kicad-jlcpcb-tools/commit/1bbae0f252927469f929b8575bad5881608db7fc fixes the problem.