Closed whmountains closed 5 months ago
I tried replacing if is_nightly(GetBuildVersion()):
with if True:
and while that got it to use the KiCad V7 routine, my file was still not updated. So it looks like a new regex will be needed for kicad v8.
@computergeek1507 Can you look into this, please?
Is it okay if I drop v6 support, what are the versions you would like to support?
Yes, you can drop v6 support (see #405 ) I would like to support V7, V8 and V8.99.
It will be amazing to keep v6 if possible (even if it is not supported anymore) as I have lot of old design with KiCad v6 that I do not want to switch to KiCad v7 or v8 as KiCad v6 is rock stable and to avoid some issues ... (I think I'm not the only one in that case)
@bvernoux I totally understand and would not delete code that works for v6 if it not stands in the way of any future support, at least for a while.
Fixed in #433
@Bouni @computergeek1507 thank you so much for your work on this!
I just tested it, and unfortunately it corrupted my schematic file. To make matters worse I was an idiot and didn't make backups before testing for the first time. I want to help debug this. I'd be happy to privately send the schematic file to either of you to see what went wrong. In the mean time hopefully I will be able to manually edit the file to get back in business.
😬 oh No, I didn't test the function myself before merging. Hopefully you can fix the issue.
If you want you can email me the file (bouni-kicad-plugin@owee.de) so that I can take a look tomorrow.
send it to me at scooter_seh(at)yahoo(dot)com
@Bouni @computergeek1507 thank you so much for your work on this!
I just tested it, and unfortunately it corrupted my schematic file. To make matters worse I was an idiot and didn't make backups before testing for the first time. I want to help debug this. I'd be happy to privately send the schematic file to either of you to see what went wrong. In the mean time hopefully I will be able to manually edit the file to get back in business.
Wow, thank both for replying so quicky!! I was able to restore the file from an auto-backup. 🎉 I sent the full KiCAD project to both of you. The non-working schematic is suffixed BROKEN in the filename.
Attached below is the diff created when I assign the number from a single part, as well as a screenshot of an error when KiCAD tries to open the resulting schematic. The only other "change" my difftool can detect is an extra newline at the end of the file. But I doubt that matters at all.
Staring at that diff, isn't there just a missing parenthesis?
the plugin also makes a copy of the schematic file and adds "_old" before editing it. If it gets corrupts, delete the file and rename the "_old" file to get the original file back
Looks like this is fixed in 3959138. Thanks!
Export to schematic doesn't work on KiCAD v8. No error is displayed, but the LCSC field doesn't show up in the schematic.
I notice that the log loads my schematic as if it were kicad v6, not even v7, which is obviously incorrect. I believe this is caused by the is_nightly check in schematicexport.py.
Thanks for your great work on this plugin! Other than that one issue, it has basically worked perfectly on v8.
KiCad Version