Bouni / kicad-jlcpcb-tools

Plugin to generate BOM + CPL files for JLCPCB, assigning LCSC part numbers directly from the plugin, query the JLCPCB parts database, lookup datasheets and much more.
MIT License
1.08k stars 102 forks source link

Fix missing rotation corrections display in the main view #445

Closed gyohng closed 2 months ago

gyohng commented 2 months ago

This patch corrects an issue where the rotation data was not being displayed correctly in the UI due to type recognition problems with the wx framework. Previously, certain rotation correction values were not converted to strings before adding to a wx list, leading to them being ignored by the GUI framework, showing no data and not reporting any errors.

The fix involves explicit string conversion of the rotation data in the populate_footprint_list method. Specifically, when correction rules are applied based on part names or packages, the corrected rotation values (part[8]) are now converted to strings (str(correction)) before being set. This change ensures that the wx framework recognises and displays the data correctly.

Please refer to this picture: image