search

Bouni / kicad-jlcpcb-tools

Plugin to generate BOM + CPL files for JLCPCB, assigning LCSC part numbers directly from the plugin, query the JLCPCB parts database, lookup datasheets and much more.
MIT License
1.08k stars 102 forks source link

Cmm crash fix #478

Closed chmorgan closed 1 month ago

KnightHill commented 1 month ago

Installed the fix and downloaded all jclpbc parts. Everything seems to be back to normal now (kicad 8.0.2 under Manjaro). Thank you so much for fixing the issue!

chmorgan commented 1 month ago

@Bouni can you review and merge if this looks good? Would like to get this out and released since it's affecting most users.

Bouni commented 1 month ago

Thanks @chmorgan for digging into this.

The log function needs an overhaul anyway. I've stolen it from KiBuzzard plugin and it has sometimes strange behavior. I would really like it if we could write to a log file as well (maybe that can be enabled in the settings!?) What do you think?

chmorgan commented 1 month ago

I think the odd behavior is fixed with this pr and imo it’s necessary to marshal the events due to widgets threading restrictions, or maybe I’m wrong here?

Agree on the log file. That could help a ton with debugging issues.

On Wed, May 29, 2024 at 10:43 AM bouni @.***> wrote:

Thanks @chmorgan https://github.com/chmorgan for digging into this.

The log function needs an overhaul anyway. I've stolen it from KiBuzzard plugin and it has sometimes strange behavior. I would really like it if we could write to a log file as well (maybe that can be enabled in the settings!?) What do you think?

— Reply to this email directly, view it on GitHub https://github.com/Bouni/kicad-jlcpcb-tools/pull/478#issuecomment-2137593480, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJH4AFK6AFMK6YCSFFYWY3ZEXSS5AVCNFSM6AAAAABIKJVA2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZXGU4TGNBYGA . You are receiving this because you were mentioned.Message ID: @.***>