search

Bouni / kicad-jlcpcb-tools

Plugin to generate BOM + CPL files for JLCPCB, assigning LCSC part numbers directly from the plugin, query the JLCPCB parts database, lookup datasheets and much more.
MIT License
1.08k stars 102 forks source link

BOM is written CPL content instead of BOM on 2024.06.02 #481

Closed cr1tbit closed 2 weeks ago

cr1tbit commented 3 weeks ago

Hi @Bouni

You should probably revert this ASAP because it already propagated to the kicad repository.

https://github.com/Bouni/kicad-jlcpcb-tools/blob/5d497a5228437b4b703a32e1a89ba2de8f1dc3a0/fabrication.py#L294C1-L294C62

It probably wasn't intended, but if it was, jlc seems not to accept this format of BOM.

image

Best regards

cr1tbit commented 3 weeks ago

I confirmed, [2024.06.01] works ok

Bouni commented 3 weeks ago

Oh snap. I'll fix it later today

Thanks for pointing this out.

Maybe a good time to add unit tests, just have to figure out how to do that properly

mikesmitty commented 2 weeks ago

@Bouni it looks like just the Comment and Designator column headers are swapped in the BOM output, I've been swapping the header manually before uploading it and the site processes it correctly

Adesin-fr commented 2 weeks ago

@Bouni it looks like just the Comment and Designator column headers are swapped in the BOM output, I've been swapping the header manually before uploading it and the site processes it correctly

Same here ;) File is not recognized at JLCPCB !

Bouni commented 2 weeks ago

Please test the latest release, the issue should be fixed now