Bouni / luxtronik

Luxtronik integration for Home Assistant
MIT License
82 stars 14 forks source link

Changed Domain Name for Entities #53

Open mneundorfer opened 1 year ago

mneundorfer commented 1 year ago

Hi there,

after the update to 2022.12.02 (from 0.1.30, I think...), all my entity names have changed. Instead of being prefixed with luxtronik as domain name, all are named in the sensor domain, now.

I'm not sure if this is on purpose, at least I didn't find it in the release notes. Without having tried to get a deep understanding of the code base, to me it feels it could have something to do with this change. I have cross-checked by using the sensor.py from my backup, which does not contain this change, and suddenly I had my old entity IDs back.

Roemer commented 1 year ago

I see the same here. Wonder if it was on purpose or not, before I adjust everything.

tetsuo55 commented 1 year ago

It's by design, meeting the new standards of home assistant

mneundorfer commented 1 year ago

Hm.. Are you aware if hass does provide any option to "override" this? Or would if be required to have it configurable in this plugin?

Reason I'm asking is that such a change for me not only means that I have to adapt my hass config, but also have to migrate all my InfluxDB time series, which's names would not match anymore

corneel27 commented 1 year ago

It would have been much better that this was mentioned as a "breaking change" as a remark before the upgrade.

Bouni commented 1 year ago

I have to apologize to all of you but I wasn't really aware that this will result in so much trouble 😟

I'm not aware of any way to override this. But in the long run this should be woth it because as far as I can tell we wouldn't be able to use a luxtronik.xxx sensor within the energy dashboard for example which was reqested frequently over the years.

So again, sorry for the inconvenience this brought with it!

tetsuo55 commented 1 year ago

Hm.. Are you aware if hass does provide any option to "override" this? Or would if be required to have it configurable in this plugin?

Reason I'm asking is that such a change for me not only means that I have to adapt my hass config, but also have to migrate all my InfluxDB time series, which's names would not match anymore

How do you migrate them?

Bouni commented 1 year ago

It seems that you can't rename your fields:

https://community.influxdata.com/t/renaming-field-names-of-stored-data/22214/2

But you can read all of them an write them back with a new name

mneundorfer commented 1 year ago

@Bouni For starters, I don't blame you! After all, this is an OSS project you are maintaining in your spare time, so thanks for that.

@tetsuo55 No idea yet. I've been doing something similar last year, (basically copying the data into a new series, probably similar to what @Bouni linked) but it was a pain and didn't really work out that well, since some tags were not copied as I expected. I'm probably gonna take some time over Christmas to get a better understanding of the current state and figure out a migration strategy.

Roemer commented 1 year ago

Is there a way to prefix the sensor names? I added friendly names, eg Aussentemperatur, so it was named luxtronik.aussentemperatur now it is just sensor.aussentemperatur. Can I have sensor.luxtronik_aussentemperatur? Or do I need to add the Luxtronik prefix to all friendly names?

Bouni commented 1 year ago

Or do I need to add the Luxtronik prefix to all friendly names?

This!

I never understood why ha does not allow for some kind of namespaces like sensor.luxtronik.xyz