search

Bouni / luxtronik

Luxtronik integration for Home Assistant
MIT License
82 stars 13 forks source link

Derive the unique_id from the sensor name #56

Open remuslazar opened 1 year ago

remuslazar commented 1 year ago

This leads to more "stable" unique_ids, not losing the history data after changing the friendly_name property in the configuration.

remuslazar commented 1 year ago

@Bouni this is surely a kind-of "breaking change" and will reset all existing history data for all luxtronik entities..

Bouni commented 1 year ago

@remuslazar @BenPru I think from now on we should only work on a dev branch. No more changes to main until the merge (on is done. Once that is the case we can also apply the PR's and release a shiny new version that maybe breaking again but that hopefully for the last time (at least in a while).

@remuslazar please rebase this to the dev branch

remuslazar commented 7 months ago

@Bouni sorry for the long delay here.. I have somehow missed your request. Anyway, the code was already on top of the dev branch so I have just changed the base for this PR.

btw: it will be nice to have a current release of luxtronik, this package being currently pinned to 0.3.14 which does not support new entities, e.g. HUP_PWM I was trying to use recently. Could you do that, can I help somehow here?

Thanks!