Bouni / luxtronik

Luxtronik integration for Home Assistant
MIT License
82 stars 13 forks source link

Renaming this integration #62

Open BenPru opened 1 year ago

BenPru commented 1 year ago

I am currently trying to process and provide my further development of this integration as a ha core integration. We had already discussed renaming this integration in the past. Do you still want to tackle this? luxtronik_legacy or similar?

AJediIAm commented 1 year ago

If I recall correctly, HA will prioritize an internal integration over a HACS integration with the same name. Renaming this integration will ensure existing users can choose which integration they want to use, but it's not blocking to add the luxtronic core integration.

BenPru commented 1 year ago

If I recall correctly, HA will prioritize an internal integration over a HACS integration with the same name. Renaming this integration will ensure existing users can choose which integration they want to use, but it's not blocking to add the luxtronic core integration.

Okay, good to know.

Bouni commented 1 year ago

As I mentioned in @BenPru 's PR https://github.com/home-assistant/core/pull/59788#issuecomment-1186806884 I'll happily rename this integration in favor of his if it gets merged into core to avoid misunderstandings.

Maybe we should try to name it luxtronik2 instead of luxtronik because I have a request of someone if I could help create an integration for a Luxtronik1 controller. The underlying protocoll is completely different from the one used by luxtronik2 controllers so supporting both in one integration is pointless in my eyes ...

Let me know what you think!

BenPru commented 1 year ago

luxtronik2

This conflicts with my current integration. 😵‍💫 But the only reason to install your luxtronik and my luxtronik2 at the same time is for different heatpumps in the same network. And this can handle my new integration out of the box. The only thing... I currently working to detect a luxtronik2 integration installation, import two config values (CONF_CONTROL_MODE_HOME_ASSISTANT + CONF_HA_SENSOR_INDOOR_TEMPERATURE), set the sensor unique id to luxtronik2 and disable the legacy luxtronik2 integration.

In the normal case I use %sensor_domain%.luxtronik_%serial_number%_%name% (e.g. climate.luxtronik_123456-047_domestic_water). But if I detect a legacy luxtronik2 integration I set this to %sensor_domain%.luxtronik2_%name% (e.g. climate.luxtronik2_domestic_water) for the first heatpump to prevent the sensor history.

Long talking, short message: luxtronik2 is possible.