Closed kbabioch closed 1 year ago
It seems like the datatypes Pulses and Count are redundant:
Pulses
Count
https://github.com/Bouni/python-luxtronik/blob/c78ea22dbd5d557522d707e4e1f526cbdba07893/luxtronik/datatypes.py#L126-L129
https://github.com/Bouni/python-luxtronik/blob/c78ea22dbd5d557522d707e4e1f526cbdba07893/luxtronik/datatypes.py#L326-329
Instances where it is used:
https://github.com/Bouni/python-luxtronik/blob/c78ea22dbd5d557522d707e4e1f526cbdba07893/luxtronik/calculations.py#L140
https://github.com/Bouni/python-luxtronik/blob/c78ea22dbd5d557522d707e4e1f526cbdba07893/luxtronik/calculations.py#L101-L103
From my point of view this could be consolidated, since the semantics in those cases is the same.
Any objections?
It seems like the datatypes
Pulses
andCount
are redundant:https://github.com/Bouni/python-luxtronik/blob/c78ea22dbd5d557522d707e4e1f526cbdba07893/luxtronik/datatypes.py#L126-L129
https://github.com/Bouni/python-luxtronik/blob/c78ea22dbd5d557522d707e4e1f526cbdba07893/luxtronik/datatypes.py#L326-329
Instances where it is used:
https://github.com/Bouni/python-luxtronik/blob/c78ea22dbd5d557522d707e4e1f526cbdba07893/luxtronik/calculations.py#L140
https://github.com/Bouni/python-luxtronik/blob/c78ea22dbd5d557522d707e4e1f526cbdba07893/luxtronik/calculations.py#L101-L103
From my point of view this could be consolidated, since the semantics in those cases is the same.
Any objections?