Closed gerw closed 6 months ago
Does anybody know, why black
is complaining? Has the configuration or the black
version changed?
I guess its a version mismatch between the pre-commit-config and the CI
CI:
Run pip install black
Collecting black
Downloading black-24.1.1-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (73 kB)
pre-commit
repos:
- repo: https://github.com/psf/black
rev: 22.12.0
We should drop black altogether in favour of ruff in my opinion. I'll submit a PR soon
@gerw If you could review #149 and rebase after the merge I will merge this one
@gerw Can you please rebase this one as well?
Coverage Report
File Stmts Miss Cover Missing luxtronik __init__.py 143 110 23% 39–55, 62–67, 70, 74–79, 84–88, 101–104, 111, 115, 119, 123, 134, 137–140, 143–163, 166–181, 184–201, 204–219, 223–225, 229–230, 234–235 __main__.py 21 21 0% 3–49 datatypes.py 275 12 96% 38, 43, 48, 58, 73–76, 81–84, 93 discover.py 43 34 21% 26–78 luxtronik/scripts dump_changes.py 44 44 0% 5–93 dump_luxtronik.py 28 28 0% 5–64 TOTAL 637 249 61%
Tests | Skipped | Failures | Errors | Time |
---|---|---|---|---|
116 | 4 :zzz: | 0 :x: | 0 :fire: | 0.666s :stopwatch: |
@Bouni: Hurray! :)
Do you know why the bot did not edit the old commit? Is it due to the fact that the old commit was spawned from another work flow? Maybe I just push another time to this branch to see what is happening.
Yes, this seems to be the case. The second coverage comment has been edited after the latest push. :partying_face:
Coverage Report