Bouni / python-luxtronik

python-luxtronik is a library that allow you to interact with a Luxtronik heatpump controller.
MIT License
37 stars 19 forks source link

Add some heatpump codes #145

Closed gerw closed 6 months ago

github-actions[bot] commented 6 months ago

Coverage

Coverage Report
FileStmtsMissCoverMissing
luxtronik
   __init__.py13410621%38–54, 61–66, 69–73, 79, 83, 102–113, 116–119, 122–142, 145–160, 163–180, 183–198, 202–204, 208–209, 213–214
   __main__.py21210%2–48
   datatypes.py2351295%37, 42, 47, 57, 72–75, 80–83, 92
   discover.py433421%25–77
luxtronik/scripts
   dump_changes.py44440%5–93
   dump_luxtronik.py28280%5–64
TOTAL58824558% 

Tests Skipped Failures Errors Time
110 4 :zzz: 0 :x: 0 :fire: 0.631s :stopwatch:
gerw commented 6 months ago

Does anybody know, why black is complaining? Has the configuration or the black version changed?

Bouni commented 6 months ago

I guess its a version mismatch between the pre-commit-config and the CI

CI:

Run pip install black
Collecting black
  Downloading black-24.1.1-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (73 kB)

pre-commit

repos:
  - repo: https://github.com/psf/black
    rev: 22.12.0

We should drop black altogether in favour of ruff in my opinion. I'll submit a PR soon

Bouni commented 6 months ago

@gerw If you could review #149 and rebase after the merge I will merge this one

Bouni commented 6 months ago

@gerw Can you please rebase this one as well?

github-actions[bot] commented 6 months ago

Coverage

Coverage Report
FileStmtsMissCoverMissing
luxtronik
   __init__.py14311023%39–55, 62–67, 70, 74–79, 84–88, 101–104, 111, 115, 119, 123, 134, 137–140, 143–163, 166–181, 184–201, 204–219, 223–225, 229–230, 234–235
   __main__.py21210%3–49
   datatypes.py2751296%38, 43, 48, 58, 73–76, 81–84, 93
   discover.py433421%26–78
luxtronik/scripts
   dump_changes.py44440%5–93
   dump_luxtronik.py28280%5–64
TOTAL63724961% 

Tests Skipped Failures Errors Time
116 4 :zzz: 0 :x: 0 :fire: 0.666s :stopwatch:
gerw commented 6 months ago

@Bouni: Hurray! :)

Do you know why the bot did not edit the old commit? Is it due to the fact that the old commit was spawned from another work flow? Maybe I just push another time to this branch to see what is happening.

gerw commented 6 months ago

Yes, this seems to be the case. The second coverage comment has been edited after the latest push. :partying_face: