search

Bouni / python-luxtronik

python-luxtronik is a library that allow you to interact with a Luxtronik heatpump controller.
MIT License
37 stars 19 forks source link

Dev: Drop black in favour of ruff #148

Closed Bouni closed 6 months ago

Bouni commented 6 months ago

We should drop black as our formatter in favour of ruff and in the same take drop pylint and fully move towards ruff. Just one dependency and way faster.

gerw commented 6 months ago

Just one question from my side: How can I call ruff locally in order to be sure that I do not get complains in a pull request? When I do just ruff format --check, I get the following on the clean repo:

> ruff format --check
Would reformat: luxtronik/__init__.py
Would reformat: luxtronik/discover.py
Would reformat: luxtronik/parameters.py
Would reformat: luxtronik/scripts/dump_changes.py
Would reformat: luxtronik/scripts/dump_luxtronik.py
5 files would be reformatted, 12 files already formatted

(Or is ruff format currently not used for checking pull requests?)