Closed Bouni closed 6 months ago
@gerw My guess was wrong, this prints (HEAD detached at pull/152/merge) 1fcdeb4 Merge c97a155cc37e44e42515b7721cf4b8340826235d into 3d94a5903fe1e104531bd481e4277dfc11668f1a
for git branch -v
😕
@kbabioch Do you have an idea why the test seem to run on the wrong files ?
Edit: I mean why the tests in #151 do seemingly not run against the files in the PR itself
Coverage Report
File Stmts Miss Cover Missing luxtronik __init__.py 143 110 23% 39–55, 62–67, 70, 74–79, 84–88, 101–104, 111, 115, 119, 123, 134, 137–140, 143–163, 166–181, 184–201, 204–219, 223–225, 229–230, 234–235 __main__.py 21 21 0% 3–49 datatypes.py 275 12 96% 38, 43, 48, 58, 73–76, 81–84, 93 discover.py 43 34 21% 26–78 luxtronik/scripts dump_changes.py 44 44 0% 5–93 dump_luxtronik.py 28 28 0% 5–64 TOTAL 637 249 61%
Tests | Skipped | Failures | Errors | Time |
---|---|---|---|---|
116 | 4 :zzz: | 0 :x: | 0 :fire: | 0.681s :stopwatch: |
Ok I think pull_request_target
is indeed the problem, the tests for the trigger pull_request
succeed!
I would like to merge the pytest CI workflow with pull_request_target
replaced with pull_request
and see if that works for #151 as well.
At the moment this fails becuause the test file contains -7
in main and my branch but I don't want to fix this in here now so that we see if #151 succeds when rebased after this one merged.
Any thoughts?
LGTM. Thank you!
This is an attempt to fix the pytest issue surfaced in #151