Bouni / python-luxtronik

python-luxtronik is a library that allow you to interact with a Luxtronik heatpump controller.
MIT License
37 stars 19 forks source link

Fix coverage #154

Closed Bouni closed 6 months ago

Bouni commented 6 months ago

Next attempt, this time I try what Chat GPT thinks is the right way of doing this

github-actions[bot] commented 6 months ago

Coverage

Coverage Report
FileStmtsMissCoverMissing
luxtronik
   __init__.py14311023%39–55, 62–67, 70, 74–79, 84–88, 101–104, 111, 115, 119, 123, 134, 137–140, 143–163, 166–181, 184–201, 204–219, 223–225, 229–230, 234–235
   __main__.py21210%3–49
   datatypes.py2751296%38, 43, 48, 58, 73–76, 81–84, 93
   discover.py433421%26–78
luxtronik/scripts
   dump_changes.py44440%5–93
   dump_luxtronik.py28280%5–64
TOTAL63724961% 

Tests Skipped Failures Errors Time
116 4 :zzz: 0 :x: 0 :fire: 0.664s :stopwatch:
Bouni commented 6 months ago

@gerw Not sure if this does the trick. Would you mind doing another merge and rebase?

gerw commented 6 months ago

Nope. From my very little understanding, it seems that the git workflow is running in my repository (for a PR from my fork), and this does not have access to stuff from this repo (e.g., to GITHUB_TOKEN). But I might be wrong.