Two staged coverage comment attempt

Bouni / python-luxtronik

python-luxtronik is a library that allow you to interact with a Luxtronik heatpump controller.

MIT License

37 stars 19 forks source link

Two staged coverage comment attempt #156

Closed Bouni closed 6 months ago

Bouni commented 6 months ago

This is a two staged approach to fix the permission problme when posting the coverage report on a PR that fomes from a forked repo.

Found here:

https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
https://github.com/MishaKav/pytest-coverage-comment/issues/68#issuecomment-1836219787

Bouni commented 6 months ago

@gerw I think this could work but we will only see if you again merge this. I'm soory that this is such a pain but I also don't want to push to main directly ...

gerw commented 6 months ago

The coverage workflow did not run in #150. Maybe we need the name Run unit tests and not the file name in https://github.com/Bouni/python-luxtronik/blob/0c58586e5725b322e87c1a021b98300118273239/.github/workflows/coverage.yml#L5 ?

Bouni commented 6 months ago

I think you're right, I'll submit another PR in a few minutes